Python 3 support and command line fixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2 is EOL, and Python 3 has been out for about ten years now. Implicit relative imports are deprecated in Python 3, make it an explicit relative import. StringIO has moved to the io package.
The lxml bindings generates bytes, not strings. However, file primitives
are Unicode-aware by default in Python 3, so write() will expect strings
unless the file was opened in raw mode (by adding 'b' to the flags):
Traceback (most recent call last):
[...]
File ".../geometry/svg_utils.py", line 49, in write_svg
f.write(xml_str);
TypeError: write() argument must be str, not bytes
array.has_key() was deprecated in Python 3 and will now throw errors:
Traceback (most recent call last):
[...]
File ".../geometry/primitives.py", line 130, in append_to_svg
if style.has_key('stroke'):
AttributeError: 'dict' object has no attribute 'has_key'
The type of this parameter is a positive float, so we should assign a
float to it. Otherwise, get_geometry() will complain when passed None:
Traceback (most recent call last):
File "./gear.py", line 318, in <module>
run_with_args()
File "./gear.py", line 302, in run_with_args
geom = g.get_geometry(args.r, args.k, args.b)
File "./gear.py", line 232, in get_geometry
if bore > 0:
TypeError: '>' not supported between instances of 'NoneType' and 'int'
Having a shebang in gear.py also removes ambiguity about which python version to use.
|
Mmmh. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 has been out for over ten years, and end-of-life for Python 2 is very near. This pull-request ports the project to Python 3, fixes some problems with command line usage (maybe related to Python 3 support), and also fixes the problems addressed in #1 and #4.