unsafeBytesToString: Fix Go 1.16 SliceHeader vet warnings #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.16 added new vet warnings to check for unsafe uses of reflect.SliceHeader. To fix them, create an empty slice, then alter that slice using *reflect.SliceHeader/Stringheader. This is apparently safer because it works with escape analysis and garbage collection [1]. The pattern used here is also used in golang.org/x/sys, so I think this should be safe. [1] golang/go#40701 Fixes: value.go:149:35: possible misuse of reflect.StringHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.16 added new vet warnings to check for unsafe uses of
reflect.SliceHeader. To fix them, create an empty slice, then alter
that slice using *reflect.SliceHeader/Stringheader. This is
apparently safer because it works with escape analysis and garbage
collection [1]. The pattern used here is also used in
golang.org/x/sys, so I think this should be safe.
[1] golang/go#40701
Fixes:
value.go:149:35: possible misuse of reflect.StringHeader