Move in memory handler to the separate module. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request richardgirges#116 from RomanBurunkov/master
Assign module.exports directly to the main module function(since it is currenlty only one function which could be used from outside).
Change tempFileHandler declaration.
Moving memory upload handler to the sepate file to separate logic for upload handling and in attempt to unificate upload handler interface.
Use common upload handler interface instead of variants of in memory and temp file handlers with checking useTempFiles option.
Generalization of the upload handler interface.
Generalization of the upload handler interface.
Add size option
Add file size loging in debug mode Return empty string for getFilePath method.
1 similar comment
complete function returns empty buffer since uploaded to the temporary file.
|
@RomanBurunkov thanks for this. Would you mind emailing me, I'd like to chat with you about something separately: richardgirges@gmail.com |
|
@RomanBurunkov I noticed the coverage decreased significantly, curious if this is someting you see on your side when running the tests? |
|
@richardgirges , I believe the coverage rate had increased becasue we now have one more file for the same functionality. And probably because there are two different separate modules for differend handlers. At least that looks more logical, but I'm not sure coverals asses that ;) And yes I saw the same things on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves memHandler in separate module and adds alpha version of file size to the module output.
That also should fix issue #118