Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numFilesLimitHandler option so user can provide handler for busboy's filesLimit event #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jseppi
Copy link

@jseppi jseppi commented Oct 27, 2020

This is a re-attempt at #152.

It adds a new configuration option, numFilesLimitHandler, so that the consumer can provide a handler function when busboy's 'filesLimit' event is triggered. This event is triggered when the number of files uploaded surpasses the specific limits.files.

@jseppi jseppi force-pushed the add-numFilesLimitHandler-option branch from 58ca337 to 441924a Compare October 27, 2020 22:16
@jseppi
Copy link
Author

jseppi commented Oct 27, 2020

@jseppi
Copy link
Author

jseppi commented Oct 28, 2020

Ah, the test is failing in master as well:

image

https://travis-ci.com/github/richardgirges/express-fileupload

@gweiying
Copy link

gweiying commented Aug 3, 2022

Is there any plan to pick up this PR where it was left off?

My current workaround (middleware to check the array length and throw an error) feels clunky, would be down to help with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants