test: add basic test #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
force-pushed
the
actions
branch
4 times, most recently
from
42ba553 to
ba566f3
Compare
|
xref: nodejs#66 |
srl295
reviewed
Sep 27, 2021
Comment on lines
+28
to
+30
| }, | ||
| "dependencies": { | ||
| "icu4c-data": "^0.67.2" |
There was a problem hiding this comment.
accidental. Running 'npm i' locally adds this.
Suggested change
| }, | |
| "dependencies": { | |
| "icu4c-data": "^0.67.2" |
srl295
reviewed
Sep 27, 2021
| @@ -4,7 +4,8 @@ | |||
| "description": "install 'full-icu' data for your current node", | |||
| "scripts": { | |||
| "lint": "standard", | |||
| "postinstall": "node postinstall.js" | |||
| "postinstall": "node postinstall.js", | |||
srl295
reviewed
Sep 27, 2021
Comment on lines
+7
to
+29
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| container: | ||
| # Official Node.js images. | ||
| - node:12 | ||
| - node:14 | ||
| - node:16 | ||
| # RHEL Node.js builds are icu_small without installing the | ||
| # optional nodejs-full-i18n rpm. | ||
| - registry.access.redhat.com/ubi8/nodejs-12 | ||
| - registry.access.redhat.com/ubi8/nodejs-14 | ||
| - registry.access.redhat.com/ubi8/nodejs-16 | ||
| container: | ||
| image: "${{ matrix.container }}" | ||
| # Need to specify user for the official node images otherwise | ||
| # npm warns `cannot run in wd` and fails to install. | ||
| options: "--user 1001" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - run: npm i | ||
| - run: npm run test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.