src: remove base64 from process.versions

The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: nodejs#52714
richardlau · Jun 13, 2024 · b06b82f · b06b82f
1 parent 756b397
commit b06b82f
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 11 deletions.
diff --git a/src/base64_version.h b/src/base64_version.h
diff --git a/src/node_metadata.cc b/src/node_metadata.cc
@@ -2,7 +2,6 @@
 #include "acorn_version.h"
 #include "ada.h"
 #include "ares.h"
-#include "base64_version.h"
 #include "brotli/encode.h"
 #include "cjs_module_lexer_version.h"
 #include "llhttp.h"
@@ -112,7 +111,6 @@ Metadata::Versions::Versions() {
 
   acorn = ACORN_VERSION;
   cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
-  base64 = BASE64_VERSION;
   uvwasi = UVWASI_VERSION_STRING;
 
 #if HAVE_OPENSSL

diff --git a/src/node_metadata.h b/src/node_metadata.h
@@ -50,8 +50,7 @@ namespace node {
   V(simdutf)                                                                   \
   V(ada)                                                                       \
   NODE_VERSIONS_KEY_UNDICI(V)                                                  \
-  V(cjs_module_lexer)                                                          \
-  V(base64)
+  V(cjs_module_lexer)
 
 #if HAVE_OPENSSL
 #define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)

diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js
@@ -22,7 +22,6 @@ const expected_keys = [
   'simdutf',
   'ada',
   'cjs_module_lexer',
-  'base64',
 ];
 
 const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');