Skip to content

Fix missing using in polyfill #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardsondev merged 1 commit into from
Sep 12, 2024
Merged

Fix missing using in polyfill #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/Task/Polyfills/ListExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,22 +51,23 @@ public static async Task ForEachAsync<TSource>(
if (body == null) throw new ArgumentNullException(nameof(body));
if (degreeOfParallelism < 1) throw new ArgumentOutOfRangeException(nameof(degreeOfParallelism), "Degree of parallelism must be at least 1.");

var semaphore = new SemaphoreSlim(degreeOfParallelism);

var tasks = source.Select(async item =>
using (var semaphore = new SemaphoreSlim(degreeOfParallelism))
{
await semaphore.WaitAsync();
try
{
await body(item);
}
finally
var tasks = source.Select(async item =>
{
semaphore.Release();
}
});
await semaphore.WaitAsync().ConfigureAwait(false);
try
{
await body(item).ConfigureAwait(false);
}
finally
{
semaphore.Release();
}
});

await Task.WhenAll(tasks);
await Task.WhenAll(tasks).ConfigureAwait(false);
}
}
}
}