Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient and HttpResponseHandler "Respond" extensions don't actually work properly #39

Closed
EffortlessFury opened this issue Aug 20, 2017 · 3 comments

Comments

@EffortlessFury
Copy link

c70bf4f

Your tests directly invoke the "SendAsync" method of your custom handler, thus they pass; however, utilizing your custom handler within an HttpClient and attempting to pass the request to a different HttpClient/Handler will fail with the following error:

The request message was already sent. Cannot send the same request message multiple times.

Am I not understanding the correct usage of these extension methods or is this an accidental oversight?

@richardszalay
Copy link
Owner

That's a really good point - I'd say it's an oversight.

Let me look into the HttpClient source to see if there's a logical way of working around the issue.

@richardszalay
Copy link
Owner

This has been fixed but is blocked by #41 as without that I can't get a release out.

@richardszalay
Copy link
Owner

This is fixed in 1.5.1 (just released)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants