Added ThMS:35 Magical Style The Onyx Path #229
Conversation
First try with one traits file + one attributes file. I'm not entirely satisfied with this, as the separate advantages and the limitations on Threshold Magery cannot give percentage bonuses to the attributes as they should per RAW (Thaumatology 76) in GCS v5.10.x - any ideas how to better do this?
Written up Style and added spells, converted Spells to new defaults up to Circle 4 - Circles 5 +6 missing; also awaiting feedback from discord on Naming & keeping default Magic prereqs
Completed The Onyx Path style. Re-adding default spell prereqs would be a hassle.
Finished the magical style The Onyx Path. All spells now have both the Onyx Path prereqs and the default prereqs.
Renaming needed to make spell prerequisites based on "Magery" work with this. No other effects that I can see. "Threshold-based magic" Modifier notes that the Threshold Attributes file must be loaded.
|
Okay, I think I'm fine with the edits now. It might be debatable whether the "Threshold-based magic"-Enhanced Version of "Magery" should be kept seperate in the Thaumatology folder or simply merged into Magic's standard Magery advantage. I'd keep it seperate, because the extra rules are from Th, not M. |
|
Had to adjust the three other advantages after the Threshold Magery - Magery name change. Should work as expected now. |
|
Is there a need to have the circle in the spell name when the circle is also in a tag? |
|
I did this to visibly mark those spells on the character sheet as belonging to the style; for one, some characters might want to learn a given spell both from the Onyxians and through other means (regular spell or other magical style), for another, it gives the user a visible indication that this is indeed a spell that will fulfil the changed prerequisites of the style. |
|
Where does this stand? |
|
It can be merged safely. Most of my other comments are minor. |
| { | ||
| "id": "a3d9e37d-b69d-47c2-bdaf-a565ffaf7353", | ||
| "type": "trait", | ||
| "name": "Magery", |
There was a problem hiding this comment.
This could be Magery (Threshold) or something since it would be a separate trait if it coexists with standard magery.
There was a problem hiding this comment.
I have juggled this forth and back a few times and am not entirely satisfied either way, but ended up with "Magery (Threshold-based, +0%)" with only that modified variant affecting other Threshold ads/disads because threshold mages will generally learn all the standard spells - and those all have more or less complicated prereq chains requiring "Magery". It would be a total hassle to add a seperate "Threshold Magery" or "Magery (Threshold)" trait to all those.
| { | ||
| "type": "attribute_bonus", | ||
| "attribute": "tm_threshold", | ||
| "amount": -6 |
There was a problem hiding this comment.
I am not sure if there is a good way to handle these, but I see what you are doing here. Decreasing an attribute by a percentage is tricky.
There was a problem hiding this comment.
It is not. I have meanwhile tried, in https://github.com/Liantefaron/gcs_master_library/blob/master/Library/Thaumatology/Thaumatology%20-%20Threshold%20Magic%20Traits.adq and https://github.com/Liantefaron/gcs_master_library/blob/master/Library/Settings/Attributes/Threshold%20Magic.attr, to do away with this helper attribute and create a pool with GCS-"threshold" subitems, but I don't get it to work properly.
| } | ||
| }, | ||
| { | ||
| "id": "75ae20c5-bf71-4a14-9da7-3221c0e3c788", |
There was a problem hiding this comment.
A reference would be nice.
| "name": "Magical Style Perks: The Onyx Path", | ||
| "reference": "ThMS:12", | ||
| "notes": "You can buy 1 Style Perk per 10CP in the style's spells in addition to 1 General Magical Perk per 20CP in other spells.", | ||
| "disabled": true, |
There was a problem hiding this comment.
Because this is constructed as a template, I thought it would be a good idea to only have the basic requirements active and keep the rest (Style Perk that you may only buy when all prereqs have been met; optional traits; etc.) either disabled (traits) or at 0CP invested (skills), so the Template could be applied as-is without flooding the character with things they might not (yet) have.
There was a problem hiding this comment.
Now that I see it: by that logic, I should also reduce all spells beyond Circle 1 to 0CP.
There was a problem hiding this comment.
As a template, you should just use the various choice mechanisms instead of disabling anything.
| } | ||
| ], | ||
| "name": "Optional Traits", | ||
| "disabled": true, |
|
Note: This PR has already been merged. If you're doing further work, you should start a new PR for it -- and start from the current state of the repo, too, rather than continuing on from this old point. |
For now, the Onyx Path spells have "(Onyx Path CircleNo)" added to their names and have only the circles as prerequisites (that is, default GURPS Magic prereqs have been deleted from the spells because that was easier than adding a top-level OR switch especially with spells that mix AND and OR prerequisites like spells and full or one-college Magery levels).