Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fantasy Folk - Elves to the library #266

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

ethorad
Copy link
Collaborator

@ethorad ethorad commented Jan 1, 2024

Added the traits, racial templates and profession templates from the FF: Elves book

Added the traits, racial templates and profession templates from the FF: Elves book
Copy link
Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with your other submission, I would put this in a subfolder under "Fantasy Folk".
Miscellaneous notes:

  • Attribute Substitution in "Elvish Traits" has incorrect text substitution format.
  • I would remove "Elbish Typical Traits".

@ethorad
Copy link
Collaborator Author

ethorad commented Jan 1, 2024

Happy to put in a subfolder. Should I move the existing templates in the "Fantasy Folk" folder to a subfolder "3 Edition templates" to keep it clean?

Also do you have an example of what the text substitution format should look like?

Moved the files to a subdirectory of the Fantasy Folk directory.
Also removed the "typical traits" note

Will make a further change for the alternative attribute once I know the format
@ethorad
Copy link
Collaborator Author

ethorad commented Jan 1, 2024

Made the change for the file location, and removed the typical traits.

I've had a look around the library in some likely places (Powers, Power Ups, a couple of others) but I can't spot somewhere else with Alternative Attribute, so not sure what the right text substitution format is.

Change the text substitution to use @ instead of %
(I see it also seems to have changed the order of some tags.  Didn't think I did that, but doesn't change anything ...)
@ethorad
Copy link
Collaborator Author

ethorad commented Jan 1, 2024

Actually, noticed I used % in the Alternative Attribute instead of @ for the text substitution - think that's what you were referring to. I thought it was some way to get it to amend the Innate Attack skills to reference Per instead of DX which I wasn't aware of.

Made that change

Copy link
Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amendments. Approved.

@rinickolous rinickolous merged commit 8032fd0 into richardwilkes:master Jan 2, 2024
@ethorad ethorad deleted the FantasyFolk-Elves branch January 4, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants