Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Dungeon Fantasy 20 #293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SavageGM
Copy link

Includes traits, skills, and templates (work in progress)

Includes traits, skills, and templates (work in progress)
Copy link
Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your traits are currently too descriptive. You're pasting in the whole description block from the book, which I don't think is really allowed by SJG.

"has": true,
"name": {
"compare": "is",
"qualifier": "SelectiveMagic Resistance"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still incorrect

"has": true,
"name": {
"compare": "is",
"qualifier": "Materialize skill"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one, too

Remove verbatim descriptions
Added Demon-Slayer and Undead-Slayer templates
Made minor corrections to some entries
@SavageGM
Copy link
Author

Updated DF20.
Removed verbatim descriptions.
Added Demon-slayer and Undead-Slayer templates.
Made minor corrections to some entries.

@richardwilkes
Copy link
Owner

What's the status of this? Is it ready for another look by someone?

@SavageGM
Copy link
Author

SavageGM commented Jun 13, 2024 via email

@SavageGM
Copy link
Author

SavageGM commented Jun 13, 2024 via email

@richardwilkes
Copy link
Owner

What's the issue? Perhaps this would be better if we switch to Discord to discuss. Feel free to ping me there.

@SavageGM
Copy link
Author

SavageGM commented Jun 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants