-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Dungeon Fantasy 20 #293
base: master
Are you sure you want to change the base?
Conversation
Includes traits, skills, and templates (work in progress)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your traits are currently too descriptive. You're pasting in the whole description block from the book, which I don't think is really allowed by SJG.
"has": true, | ||
"name": { | ||
"compare": "is", | ||
"qualifier": "SelectiveMagic Resistance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still incorrect
"has": true, | ||
"name": { | ||
"compare": "is", | ||
"qualifier": "Materialize skill" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one, too
Updated DF20. |
What's the status of this? Is it ready for another look by someone? |
It is ready for review.
…On Thu, Jun 13, 2024 at 3:43 PM Richard Wilkes ***@***.***> wrote:
What's the status of this? Is it ready for another look by someone?
—
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDK5XAP3GUBAD6343FF54YDZHH75RAVCNFSM6AAAAABD6ZCXXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWG4ZTINRYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Scott D. Sveter
Senior Project Manager
MBA, PMP, CSM, ITIL-F, SFC USA (ret.)
804-904-2020
<https://www.credly.com/badges/f17442f5-9bf6-4ed4-8111-2bf903516d62/linked_in_profile>
<https://bcert.me/smskmdwgg>
|
I could use help correcting it.
…On Thu, Jun 13, 2024 at 4:03 PM Richard Wilkes ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Library/Dungeon Fantasy/Dungeon Fantasy 20/Dungeon Fantasy 20
Skills.skl
<#293 (comment)>
:
> + "all": true,
+ "prereqs": [
+ {
+ "type": "trait_prereq",
+ "has": true,
+ "name": {
+ "compare": "is",
+ "qualifier": "Spellpiercer"
+ }
+ },
+ {
+ "type": "trait_prereq",
+ "has": true,
+ "name": {
+ "compare": "is",
+ "qualifier": "SelectiveMagic Resistance"
Looks like this is still incorrect
—
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDK5XAN6ZK4RTLMBCFZL2SDZHICKBAVCNFSM6AAAAABD6ZCXXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGAZDQNRXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Scott D. Sveter
Senior Project Manager
MBA, PMP, CSM, ITIL-F, SFC USA (ret.)
804-904-2020
<https://www.credly.com/badges/f17442f5-9bf6-4ed4-8111-2bf903516d62/linked_in_profile>
<https://bcert.me/smskmdwgg>
|
What's the issue? Perhaps this would be better if we switch to Discord to discuss. Feel free to ping me there. |
As soon as I can...busy with work ATM
…On Thu, Jun 13, 2024 at 4:06 PM Richard Wilkes ***@***.***> wrote:
What's the issue? Perhaps this would be better if we switch to Discord to
discuss. Feel free to ping me there.
—
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDK5XAPAAZQG7SYBFGD5W4TZHICWDAVCNFSM6AAAAABD6ZCXXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWG44TMMJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Scott D. Sveter
Senior Project Manager
MBA, PMP, CSM, ITIL-F, SFC USA (ret.)
804-904-2020
<https://www.credly.com/badges/f17442f5-9bf6-4ed4-8111-2bf903516d62/linked_in_profile>
<https://bcert.me/smskmdwgg>
|
Includes traits, skills, and templates (work in progress)