#312 Talent benefits as modifiers #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be easily swapped out.
smithkm
requested review from
richardwilkes,
rinickolous,
ethorad and
dripton
as code owners
|
I agree with the bug report. The diff looks reasonable, though it's large enough that I can't confirm that there are no typos. Looks worth merging. |
dripton
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returned the alternate benefits of talents in the Power Ups library to being modifiers so they can be easily switched between. For talents that have no alternate benefit I left the reaction bonus directly on the trait for simplicity.