-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- New parameter options/include_collection can be used to insert the collection name in the document indexed by ES
- Loading branch information
1 parent
3d90733
commit 94ed033
Showing
7 changed files
with
187 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
curl -XPUT "http://localhost:9200/_river/river101/_meta" -d @mongodb-river-simple.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
%MONGO_HOME%\bin\mongo < test-issue-101.js | ||
pause | ||
curl -XGET localhost:9200/mydb101/_search?q=collection:mycollec101 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"type": "mongodb", | ||
"mongodb": { | ||
"db": "mydb101", | ||
"collection": "mycollec101", | ||
"options": { | ||
"include_collection": "collection" | ||
} | ||
}, | ||
"index": { | ||
"name": "mydb101", | ||
"type": "type101" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
use mydb101 | ||
var o = { | ||
'name': 'issue101' | ||
} | ||
db.mycollec101.save(o) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125 changes: 125 additions & 0 deletions
125
.../java/test/elasticsearch/plugin/river/mongodb/simple/RiverMongoIncludeCollectionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
/* | ||
* Licensed to Elastic Search and Shay Banon under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. Elastic Search licenses this | ||
* file to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package test.elasticsearch.plugin.river.mongodb.simple; | ||
|
||
import static org.elasticsearch.client.Requests.countRequest; | ||
import static org.elasticsearch.common.io.Streams.copyToStringFromClasspath; | ||
import static org.elasticsearch.index.query.QueryBuilders.fieldQuery; | ||
import static org.hamcrest.MatcherAssert.assertThat; | ||
import static org.hamcrest.Matchers.equalTo; | ||
|
||
import org.elasticsearch.action.admin.indices.exists.indices.IndicesExistsRequest; | ||
import org.elasticsearch.action.count.CountResponse; | ||
import org.testng.Assert; | ||
import org.testng.annotations.AfterClass; | ||
import org.testng.annotations.BeforeClass; | ||
import org.testng.annotations.Test; | ||
|
||
import test.elasticsearch.plugin.river.mongodb.RiverMongoDBTestAsbtract; | ||
|
||
import com.mongodb.DB; | ||
import com.mongodb.DBCollection; | ||
import com.mongodb.DBObject; | ||
import com.mongodb.WriteConcern; | ||
import com.mongodb.util.JSON; | ||
|
||
@Test | ||
public class RiverMongoIncludeCollectionTest extends RiverMongoDBTestAsbtract { | ||
|
||
private static final String TEST_SIMPLE_MONGODB_RIVER_INCLUDE_COLLECTION_JSON = "/test/elasticsearch/plugin/river/mongodb/simple/test-simple-mongodb-river-include-collection.json"; | ||
private DB mongoDB; | ||
private DBCollection mongoCollection; | ||
private String includeCollectionOption = "mycollection"; | ||
|
||
protected RiverMongoIncludeCollectionTest() { | ||
super("include-river-" + System.currentTimeMillis(), "include-river-" | ||
+ System.currentTimeMillis(), "include-collection" | ||
+ System.currentTimeMillis(), "include-index-" | ||
+ System.currentTimeMillis()); | ||
} | ||
|
||
protected RiverMongoIncludeCollectionTest(String river, String database, | ||
String collection, String index) { | ||
super(river, database, collection, index); | ||
} | ||
|
||
@BeforeClass | ||
public void createDatabase() { | ||
logger.debug("createDatabase {}", getDatabase()); | ||
try { | ||
mongoDB = getMongo().getDB(getDatabase()); | ||
mongoDB.setWriteConcern(WriteConcern.REPLICAS_SAFE); | ||
super.createRiver( | ||
TEST_SIMPLE_MONGODB_RIVER_INCLUDE_COLLECTION_JSON, | ||
getRiver(), (Object) String.valueOf(getMongoPort1()), | ||
(Object) String.valueOf(getMongoPort2()), | ||
(Object) String.valueOf(getMongoPort3()), | ||
(Object) includeCollectionOption, (Object) getDatabase(), | ||
(Object) getCollection(), (Object) getIndex(), | ||
(Object) getDatabase()); | ||
logger.info("Start createCollection"); | ||
mongoCollection = mongoDB.createCollection(getCollection(), null); | ||
Assert.assertNotNull(mongoCollection); | ||
} catch (Throwable t) { | ||
logger.error("createDatabase failed.", t); | ||
} | ||
} | ||
|
||
@AfterClass | ||
public void cleanUp() { | ||
super.deleteRiver(); | ||
logger.info("Drop database " + mongoDB.getName()); | ||
mongoDB.dropDatabase(); | ||
} | ||
|
||
@Test | ||
public void testIncludeCollection() throws Throwable { | ||
logger.debug("Start testIncludeCollection"); | ||
try { | ||
String mongoDocument = copyToStringFromClasspath(TEST_SIMPLE_MONGODB_DOCUMENT_JSON); | ||
DBObject dbObject = (DBObject) JSON.parse(mongoDocument); | ||
mongoCollection.insert(dbObject); | ||
Thread.sleep(wait); | ||
|
||
assertThat( | ||
getNode().client().admin().indices() | ||
.exists(new IndicesExistsRequest(getIndex())) | ||
.actionGet().isExists(), equalTo(true)); | ||
assertThat( | ||
getNode().client().admin().indices() | ||
.prepareTypesExists(getIndex()) | ||
.setTypes(getDatabase()).execute().actionGet() | ||
.isExists(), equalTo(true)); | ||
|
||
String collectionName = mongoCollection.getName(); | ||
|
||
refreshIndex(); | ||
|
||
CountResponse countResponse = getNode() | ||
.client() | ||
.count(countRequest(getIndex()) | ||
.query(fieldQuery(includeCollectionOption, collectionName))).actionGet(); | ||
assertThat(countResponse.getCount(), equalTo(1L)); | ||
} catch (Throwable t) { | ||
logger.error("testIncludeCollection failed.", t); | ||
t.printStackTrace(); | ||
throw t; | ||
} | ||
} | ||
} |
29 changes: 29 additions & 0 deletions
29
...asticsearch/plugin/river/mongodb/simple/test-simple-mongodb-river-include-collection.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"type": "mongodb", | ||
"mongodb": { | ||
"servers": [{ | ||
"host": "localhost", | ||
"port": %s | ||
}, | ||
{ | ||
"host": "localhost", | ||
"port": %s | ||
}, | ||
{ | ||
"host": "localhost", | ||
"port": %s | ||
}], | ||
"options": { | ||
"secondary_read_preference": true, | ||
"include_collection": "%s" | ||
}, | ||
"db": "%s", | ||
"collection": "%s", | ||
"gridfs": false | ||
}, | ||
"index": { | ||
"name": "%s", | ||
"type": "%s", | ||
"throttle_size": 2000 | ||
} | ||
} |
94ed033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Richard Louapre » elasticsearch-river-mongodb #41 UNSTABLE
Looks like this commit caused a build failure
(what's this?)