Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paho MQTT v2 Callbacks #102

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Paho MQTT v2 Callbacks #102

merged 2 commits into from
Mar 5, 2024

Conversation

richibrics
Copy link
Owner

Prepared Paho MQTT to use v2, following the migration docs

@richibrics richibrics requested a review from infeeeee March 4, 2024 14:26
@infeeeee
Copy link
Collaborator

infeeeee commented Mar 5, 2024

I added a notification, so if someone starts the script accidentally with an old paho version, it will fail with a message, not with the python traceback.

I had to manually upgrade to paho v2, I run IoTuring in a venv, and I had to install it again with pip install -e .. I guess it's not common to upgrade the progam without its dependecies, but it can happen.

@infeeeee infeeeee linked an issue Mar 5, 2024 that may be closed by this pull request
@richibrics
Copy link
Owner Author

I didn't think that scenario but it's correct, if it's installed in editor mode via pip, IoTuring can be updated without updating the dependencies.

@richibrics richibrics merged commit 8819964 into main Mar 5, 2024
2 checks passed
@richibrics richibrics deleted the dev/paho_v2 branch March 7, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported callback API version
2 participants