couple of minor changes #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color selection mechanism right now is broken. For example, the highlighter stylus has 6 different colors (yellow, blue, pink, orange, green, and grey), but they all report PenColor.HIGHLIGHT as color. This changes defines a specific palette color, so highlighter lines are rendered (if all using the same color, namely the samen than YELLOW_2. The alternative (current behavior) has rmc crash, as there is no palette color associated to PenColor.HIGHLIGHT. Similar single-color issues happen for ballpoint pen and paintbrusher. For the remaining stylus (fineliner, caligraphy pen, and marker), color works well.
Just a README.md addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.