Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workflow #53

Merged
merged 6 commits into from
Nov 12, 2023
Merged

update workflow #53

merged 6 commits into from
Nov 12, 2023

Conversation

ricky0123
Copy link
Owner

fixes #48

@vercel vercel bot temporarily deployed to Preview – vad-ricky0123-com November 10, 2023 19:02 Inactive
@vercel vercel bot temporarily deployed to Preview – vad-demo-script November 10, 2023 19:02 Inactive
@vercel vercel bot temporarily deployed to Preview – vad-ricky0123-com November 10, 2023 19:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vad-demo-script November 10, 2023 19:47 Inactive
@ricky0123 ricky0123 requested a review from HayatoYagi November 10, 2023 19:49
Copy link
Contributor

@HayatoYagi HayatoYagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump the version up manually in advance, right?
Or you can add the commands below to this workflow.

npm version [patch|minor|major]
git push && git push --tags

https://docs.npmjs.com/cli/v10/commands/npm-version

.github/workflows/publish.yml Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vad-demo-script November 12, 2023 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – vad-ricky0123-com November 12, 2023 16:31 Inactive
@ricky0123
Copy link
Owner Author

We need to bump the version up manually in advance, right? Or you can add the commands below to this workflow.

npm version [patch|minor|major]
git push && git push --tags

https://docs.npmjs.com/cli/v10/commands/npm-version

Yes, for now let's bump the version up manually. It's a bit of a safeguard and we can potentially automate it in the future when we're more comfortable with the pipeline. However, if we ever do include bumping the version as part of the pipeline, we have to make sure that it only happens if the "dry-run" option is unchecked.

@vercel vercel bot temporarily deployed to Preview – vad-demo-script November 12, 2023 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – vad-ricky0123-com November 12, 2023 16:48 Inactive
@ricky0123 ricky0123 merged commit 99584e7 into master Nov 12, 2023
3 checks passed
@ricky0123 ricky0123 deleted the github-action branch November 12, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github action for deploying to npm
2 participants