-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update workflow #53
update workflow #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to bump the version up manually in advance, right?
Or you can add the commands below to this workflow.
npm version [patch|minor|major]
git push && git push --tags
Yes, for now let's bump the version up manually. It's a bit of a safeguard and we can potentially automate it in the future when we're more comfortable with the pipeline. However, if we ever do include bumping the version as part of the pipeline, we have to make sure that it only happens if the "dry-run" option is unchecked. |
fixes #48