Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple generators #8

Merged
merged 4 commits into from
Aug 2, 2022
Merged

feat: support multiple generators #8

merged 4 commits into from
Aug 2, 2022

Conversation

itsjxck
Copy link
Contributor

@itsjxck itsjxck commented Aug 2, 2022

I have a requirement to use https://github.com/notiz-dev/prisma-dbml-generator with our schema; this PR attempts to add support for multiple generator configs, with arbitrary values to hopefully open up the config to any generator someone may want to add.

@ridafkih
Copy link
Owner

ridafkih commented Aug 2, 2022

Thanks @itsjxck! Initially looking good, going to run some tests and have a look.

@ridafkih ridafkih self-requested a review August 2, 2022 23:47
@ridafkih ridafkih merged commit 25924c3 into ridafkih:main Aug 2, 2022
@ridafkih
Copy link
Owner

ridafkih commented Aug 2, 2022

Thank you for the contribution, I just made sure to add the requirement of the name attribute if supplying multiple generators.

This has been released in v0.6.0, thank you once again for your contribution!

@itsjxck itsjxck deleted the feature/support-multiple-generators branch August 3, 2022 08:43
@itsjxck
Copy link
Contributor Author

itsjxck commented Aug 3, 2022

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants