Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum CMake version to 3.5 #106

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Increase minimum CMake version to 3.5 #106

merged 1 commit into from
Dec 2, 2023

Conversation

qak
Copy link
Collaborator

@qak qak commented Nov 30, 2023

Starting with CMake 3.27, configuring libdivide prints a deprecation warning because compatibility with versions of CMake older than 3.5 is deprecated. This pull request increases the minimum CMake version from 3.4 to 3.5, which resolves the issue.

As of CMake 3.27, compatibility with versions of CMake older than 3.5 is
deprecated.
@qak
Copy link
Collaborator Author

qak commented Nov 30, 2023

It looks like the AppVeyor build failure is unrelated to the changes in this pull request.

@ridiculousfish ridiculousfish merged commit 5d083f9 into ridiculousfish:master Dec 2, 2023
1 check failed
@ridiculousfish
Copy link
Owner

Thank you!

@qak qak deleted the increase_minimum_cmake_version branch December 4, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants