Improve UI #135
Merged
Improve UI #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code produced invalid table markup: ``` <table></table> <tr><td>...</td><td>...</td></tr> <tr><td>...</td><td>...</td></tr> ``` Build the complete table HTML fragment as a string and only then attempt to append it to create the expected markup.
Instead of using block tags (DIV) and applying CSS to make them behave like inline tags, use SPAN tags. Wrap the first line of items in their own DIV tag to ensure the following content is not impacted. Make the description float so that the exta attributes can be side by side with it.
Some metrics can contain multiple lines of output generated by a CLI program that aligned information for bettear readibility (e.g. ps(1) output of the cpu metric from riemann-health). Swicth to a PRE tag to display this content preserving spacing.
Use the same color for extra attribute names than for existing ttl and tags label. While here, remove extra colon after tags to match the other labels.
When formatting a value like 7.897 with a precision of 2 digits the code was: * muliplying the value by 100 (10^precision) => 789.7; * rouding the value => 790; * dividing the value by 100 => 7.9 This is inconsistent with other float values displayed with 2 decimal digits. Prefer the toFixed method which returns a string, "7.90" in the above exapmle. Since we also have integer values, and because JS is a joke that only knows about floats, attempt to guess if the value is an integer and do not display decimals in this case to keep the previous behavor in this case.
|
Added another minor fix for rounding inconsistencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ps(1)is hard to read because of the non-monospaced font, custom attribute (customer, user) are not display like the usual ones (ttl, tags)ps(1)output, all attributes are displayed the same way