Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rm2fb #39

Closed
wants to merge 3 commits into from
Closed

Conversation

danshick
Copy link
Contributor

@danshick danshick commented Jan 5, 2021

This makes reStream work with rm2fb

When installed, rm2fb creates /dev/shm/swtfb.01, which behaves very much like the old /dev/fb0 from the rm1. To get this working, a conditional check for this file was added both to the rust binary as well as the shell script.

Additionally, I've PR'd the rust helper binary into toltec. It has been accepted into testing. If installed via toltec, the rust helper binary will end up at /opt/bin/restream. I've also made two small changes to support this additional location for the helper.

@rien
Copy link
Owner

rien commented Jan 5, 2021

Are there improvements noticeable when using the rm2fb instead of reading the process memory?

Your PR is great, but the logic for checking whether to use the alternative framebuffer makes things complicated... I'd rather not add complexity when there is no noticeable improvement.

Adding restream to toltec is great! I should start using versioning for restream!

@Eeems
Copy link

Eeems commented Jan 5, 2021

While this adds complexity, it also makes reStream usable for users who are using rm2fb in order to use other third party software. Otherwise reStream only works for xochitl without rm2fb installed.

@rien rien closed this Jan 5, 2021
@rien rien deleted the branch rien:master January 5, 2021 19:27
@rien
Copy link
Owner

rien commented Jan 5, 2021

Please reopen this PR against the new main branch.

@rien
Copy link
Owner

rien commented Jan 5, 2021

While this adds complexity, it also makes reStream usable for users who are using rm2fb in order to use other third party software. Otherwise reStream only works for xochitl without rm2fb installed.

reStream currently already works for users who are using rm2fb if I'm not mistaken?

Aha I know see the problem: users running custom software (that's not xochitl). Then this is indeed needed.

@danshick danshick mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants