Improved test cases for preserveJoinData

riesenia · Nov 29, 2019 · 5570489 · 5570489
1 parent 3093559
commit 5570489
Showing 1 changed file with 8 additions and 16 deletions.
diff --git a/tests/TestCase/Model/Behavior/DuplicatableBehaviorTest.php b/tests/TestCase/Model/Behavior/DuplicatableBehaviorTest.php
@@ -213,28 +213,20 @@ public function testPreserveJoinData()
             'contain' => [
                 'Tags',
             ],
-            'preserveJoinData' => false,
+            'preserveJoinData' => true,
         ]);
 
-        $duplicated = $this->Invoices->duplicateEntity(1);
-
-        $this->assertEquals(false, isset($duplicated->tags[0]->_joinData));
-        $this->assertEquals(false, isset($duplicated->tags[1]->_joinData));
-
-        $this->Invoices->removeBehavior('Duplicatable');
-
-        $this->Invoices->addBehavior('Duplicatable.Duplicatable', [
+        $result = $this->Invoices->duplicate(1);
+        $invoice = $this->Invoices->get($result->id, [
             'contain' => [
                 'Tags',
-            ],
-            'preserveJoinData' => true,
+            ]
         ]);
 
-        $duplicated = $this->Invoices->duplicateEntity(1);
+        $this->assertEquals(true, $invoice->tags[0]->_joinData->is_preserved);
+        $this->assertEquals(true, $invoice->tags[1]->_joinData->is_preserved);
 
-        $this->assertEquals(true, isset($duplicated->tags[0]->_joinData));
-        $this->assertEquals(true, isset($duplicated->tags[1]->_joinData));
-        $this->assertEquals(true, $duplicated->tags[0]->_joinData->is_preserved);
-        $this->assertEquals(true, $duplicated->tags[1]->_joinData->is_preserved);
+        // check that tags are not duplicated
+        $this->assertEquals(2, $this->Invoices->Tags->find()->count());
     }
 }