Fixed a bug with string setters being executed as callables #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Oct 15, 2018
| @@ -180,4 +181,25 @@ public function testWithTranslation() | |||
| ->all(); | |||
| $this->assertEquals(2, $records->count()); | |||
| } | |||
|
|
|||
| public function testDuplicateWithSetters() | |||
There was a problem hiding this comment.
This new test passes even without the change you have done to the behavior, so it's not really useful 🙂.
In general when fixing a bug write a failing test first and then fix the code.
There was a problem hiding this comment.
🤔 I'll have to revise this test.
ADmad
reviewed
Oct 16, 2018
| @@ -292,7 +292,7 @@ protected function _doAction($action, EntityInterface $entity, $prop, $value = n | |||
| break; | |||
|
|
|||
| case 'set': | |||
| if (is_callable($value)) { | |||
| if (is_callable($value) && !is_string($value)) { | |||
There was a problem hiding this comment.
Micro optimisation, the !is_string() check could be done first.
ADmad
approved these changes
Oct 16, 2018
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fixes an issue with the behaviour which arises if a setter is used and a string is passed which matches a PHP function name. The function is then executed as a callable and unknown side effects are created.
I have fixed this bug and also included a new test-case to cover the regression.
/cc @ogrrd