Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mypy in CI for static type checking #1006

Closed
karalekas opened this issue Sep 19, 2019 · 1 comment · Fixed by #1098
Closed

Use mypy in CI for static type checking #1006

karalekas opened this issue Sep 19, 2019 · 1 comment · Fixed by #1098
Assignees
@appleby
Labels
devops 🚀 An issue related to CI/CD.
Milestone
v2.14

Comments

@karalekas
Copy link
Contributor

If we continue down the path of #999 might make sense to just add this mypy type checking to the CI pipeline.
@karalekas karalekas added the devops 🚀 An issue related to CI/CD. label Sep 19, 2019
@appleby
Copy link
Contributor

appleby commented Sep 19, 2019

Some helpful hints from the mypy docs about boostrapping mypy usage in an existing codebase:

https://mypy.readthedocs.io/en/latest/existing_code.html#existing-code

@karalekas karalekas added this to the v2.13 milestone Oct 1, 2019
@karalekas karalekas mentioned this issue Oct 1, 2019
Closed
appleby added a commit that referenced this issue Nov 7, 2019
@appleby
Add "make typecheck" target and run it during gitlab CI
c0c9d00 
- Add mypy to requirements.txt
- Add mypy.ini
- Add testenv:mypy to tox.ini
- Add a make typecheck target
- Add a typecheck section to .gitlab-ci.yml

Closes #1006
@appleby appleby mentioned this issue Nov 7, 2019
Merged
5 tasks
@karalekas karalekas modified the milestones: v2.13, v2.14 Nov 7, 2019
appleby added a commit that referenced this issue Nov 8, 2019
@appleby
Add "make typecheck" target and run it during gitlab CI
a0e4acb 
- Add mypy to requirements.txt
- Add mypy.ini
- Add testenv:mypy to tox.ini
- Add a make typecheck target
- Add a typecheck section to .gitlab-ci.yml

Closes #1006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleby appleby

Labels
devops 🚀 An issue related to CI/CD.
Projects
None yet
Milestone
v2.14
Development

Successfully merging a pull request may close this issue.

Add "make typecheck" target and run it during gitlab CI rigetti/pyquil
2 participants
@appleby @karalekas