Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3 typing to the gates module #988

Closed
karalekas opened this issue Sep 10, 2019 · 2 comments · Fixed by #999
Closed

Add Python 3 typing to the gates module #988

karalekas opened this issue Sep 10, 2019 · 2 comments · Fixed by #999
Assignees
@appleby
Labels
quality 🎨 Improve code quality.
Milestone
v2.13

Comments

@karalekas
Copy link
Contributor

We migrated pyQuil to Python 3 some time ago, but still haven't gotten around to adding typing to all the modules. This issue is for doing so in the gates.py module, which is one of the most critical components of the library.
@karalekas karalekas added good first issue 👶 A place to get started. quality 🎨 Improve code quality. labels Sep 10, 2019
@karalekas karalekas added this to the v2.12 milestone Sep 11, 2019
@appleby
Copy link
Contributor

appleby commented Sep 13, 2019

If no one beats me to it, I can tackle this one. Per @stylewarning's request, not assigning myself until I actually start on it though.

appleby added a commit that referenced this issue Sep 16, 2019
@appleby
Add type annotations to the gates module
15e8e2a 
Resolves #988
@appleby appleby mentioned this issue Sep 16, 2019
Merged
14 tasks
@appleby appleby self-assigned this Sep 16, 2019
@appleby
Copy link
Contributor

appleby commented Sep 16, 2019

Had some time on the flight, so went ahead and started on this. Draft PR is up, but still a WIP.

appleby added a commit that referenced this issue Sep 17, 2019
@appleby
Add type annotations to the gates module
2e33f9e 
Resolves #988
appleby added a commit that referenced this issue Sep 23, 2019
@appleby
Add type annotations to the gates module
529cb00 
Resolves #988
@karalekas karalekas modified the milestones: v2.12, v2.13 Sep 28, 2019
@karalekas karalekas mentioned this issue Oct 1, 2019
Closed
@karalekas karalekas removed the good first issue 👶 A place to get started. label Oct 1, 2019
appleby added a commit that referenced this issue Oct 9, 2019
@appleby
Add type annotations to the gates module
01a63a8 
Resolves #988
appleby added a commit that referenced this issue Oct 30, 2019
@appleby
Add type annotations to the gates module
f967960 
Resolves #988
appleby added a commit that referenced this issue Oct 30, 2019
@appleby
Add type annotations to the gates module
0658e22 
Resolves #988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleby appleby

Labels
quality 🎨 Improve code quality.
Projects
None yet
Milestone
v2.13
Development

Successfully merging a pull request may close this issue.

Type annotations for gates, quilatom, and quilbase modules rigetti/pyquil
2 participants
@appleby @karalekas