-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark and skip particularly slow unit tests #1001
Conversation
hm |
wow I drop it from 40 to 3 and it's still too slow for you? :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be fine taking this route in the near-term to lower the barrier of entry for developers. You should update the gitlab YAML to run the slow tests, and add some information to the contribution guide about this option and which tests specifically are marked as slow.
Also need to update changelog ofc |
Alternatively we can leave this to users. I was unaware of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do this, let's just use the canonical --runslow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny tiny stuff -- also can you move your changelog entry to the bottom of the "improvements and changes" list? each section is pretty much chronological by merge date. otherwise LGTM!
Co-Authored-By: Peter Karalekas <peter@rigetti.com>
Good catches! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description
A few tests dominate the runtime of the test suite, and this makes me less likely to run tests. On my system,
This PR adds a
--include-slow-tests
flag, as well as a markerpytest.marks.slow
for indicating that certain tests are slow. I've flagged the top 3 in the above list. If we decide to move forward with this idea, probably we need to configure gitlab to add the--include-slow-tests
(since these things should be tested for a PR, for example).Checklist
auto-close keywords.
including author and PR number (@username, gh-xxx).