Update Rigetti Forest Slack Workspace invitation link #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do these invite links go out of date? I feel like maybe 6months ago we updated the link. |
notmgsk
approved these changes
Oct 8, 2019
karalekas
suggested changes
Oct 8, 2019
|
Even better would be to create a named link like in line 119 and share it between the two locations so that people never forget to update both places |
amyfbrown
changed the title
karalekas
suggested changes
Oct 9, 2019
There was a problem hiding this comment.
Looking great! Just one last thing -- although this is a very tiny change, it is a bug and should get a changelog entry, something along the lines of:
- Fixed the Rigetti Forest Slack Workspace invite link in the README (@amyfbrown, Update Rigetti Forest Slack Workspace invitation link #1042).
karalekas
changed the title
karalekas
suggested changes
Oct 10, 2019
Co-Authored-By: Peter Karalekas <peter@rigetti.com>
karalekas
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Rigetti-Forest Slack invitation link with one that has not expired. This fixes pyQuil issue #1040.
Checklist
There is a unit test that covers these changes.N/AAll new and existing tests pass locally and on Semaphore.N/AParameters have type hints with PEP 484 syntax.N/AFunctions and classes have useful sphinx-style docstrings.N/A(New Feature) The docs have been updated accordingly.N/Aauto-close keywords.
including author and PR number (@username, gh-xxx).