Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for presence of π in _expression_to_string #1076

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Test for presence of π in _expression_to_string #1076

merged 1 commit into from
Oct 28, 2019

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Oct 24, 2019 •
edited
Loading

Description

See #993 for details. This is a much simpler fix than I previously suggested.

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Semaphore.
  • [🤷‍♂] Parameters have type hints with PEP 484 syntax.
  • [🤷‍♂] Functions and classes have useful sphinx-style docstrings.
  • [🤷‍♂] (New Feature) The docs have been updated accordingly.
  • [🤷‍♂] (Bugfix) The associated issue is referenced above using
    auto-close keywords.
  • The changelog is updated,
    including author and PR number (@username, gh-xxx).

@notmgsk notmgsk requested a review from a team as a code owner October 24, 2019 13:46
@notmgsk notmgsk force-pushed the fix/really-fix-params-and-pi branch from eba67bc to 9013650 Compare October 24, 2019 13:51
ecpeterson
ecpeterson reviewed Oct 24, 2019
View reviewed changes
pyquil/quilatom.py Outdated Show resolved Hide resolved
@notmgsk
Test for presence of π in _expression_to_string
16b1272 
And use grouping where necessary.

changelog

a
@notmgsk notmgsk force-pushed the fix/really-fix-params-and-pi branch from 9013650 to 16b1272 Compare October 24, 2019 15:49
@notmgsk notmgsk requested a review from appleby October 24, 2019 15:50
appleby
appleby approved these changes Oct 24, 2019
View reviewed changes
pyquil/quilatom.py Show resolved Hide resolved
@karalekas karalekas added the bug 🐛 An issue that needs fixing. label Oct 28, 2019
@karalekas karalekas added this to the v2.13 milestone Oct 28, 2019
@karalekas karalekas merged commit 6155f4d into master Oct 28, 2019
@karalekas karalekas deleted the fix/really-fix-params-and-pi branch October 28, 2019 22:01
@karalekas karalekas mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby approved these changes

@ecpeterson ecpeterson ecpeterson approved these changes

Assignees
No one assigned
Labels
bug 🐛 An issue that needs fixing.
Projects
None yet
Milestone
v2.13
Development

Successfully merging this pull request may close these issues.
4 participants
@notmgsk @appleby @ecpeterson @karalekas