-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support instead providing a list of values to write_memory() #1114
Support instead providing a list of values to write_memory() #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, but I'd like a few sanity checks in the code for value type / length / etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to rebase onto master to resolve the make typecheck
failure.
@Tommy-Moffat Does this need to be marked as a draft? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs rebase onto master to fix semaphore, but otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple smol things and it's ready
Co-Authored-By: Peter Karalekas <peter@rigetti.com>
Co-Authored-By: Peter Karalekas <peter@rigetti.com>
Co-Authored-By: Peter Karalekas <peter@rigetti.com>
🎉 |
Description
Modified write_memory() for accepting lists in addition to values + offsets when writing to classical memory registers. Closes #658.
Checklist
auto-close keywords.
including author and PR number (@username, gh-xxx).