-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DEFGATE ... AS PAULI-SUM #1125
Conversation
5a8d201
to
550e300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments for your consideration. no blockers, happy to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if TYPE_CHECKING:
import crazy_pills_amiright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to review again but just very small stuff so far
if TYPE_CHECKING: | ||
from pyquil.paulis import PauliSum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Adds support for
DEFGATE ... AS PAULI-SUM
, which allows gate definition via an exponentiated Hamiltonian.cf. quil-lang/quil#38 , quil-lang/quilc#498
Todo
paulis.py
is not too damaging.DEFGATE ... AS PERMUTATION
.)Checklist
including author and PR number (@username, gh-xxx).