Ignore fewer flake8 rules, add flake8-bugbear #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalekas
changed the title
appleby
reviewed
Dec 24, 2019
pyquil/tests/test_noise.py
Outdated
| @@ -134,7 +134,7 @@ def test_decoherence_noise(): | |||
|
|
|||
| # verify that gate names are translated | |||
| new_prog = apply_noise_model(prog, m3) | |||
| new_gates = _get_program_gates(new_prog) | |||
| _get_program_gates(new_prog) | |||
There was a problem hiding this comment.
_get_program_gates doesn't appear to be side-effecty, nix? or else maybe the intention was to do something with new_gates?
pyquil/tests/test_quil.py
Outdated
Comment on lines
1388
to
1390
| less_trivial_pi = "3 * theta[0] * 2 / (pi)" | ||
| prog = Program(f"RX({trivial_pi}) 0") | ||
| exp = str(prog[0].params[0]) | ||
| assert _eval_as_np_pi(trivial_pi) == _eval_as_np_pi(exp) |
There was a problem hiding this comment.
perhaps the line below was actually meant to RX({less_trivial_pi}) and then _eval_as_np_pi(less_trivial_pi) on line 1391?
pyquil/tests/test_quil.py
Outdated
Comment on lines
1393
to
1394
| more_less_trivial_pi = "3 / (theta[0] / (pi + 1)) / pi" | ||
| prog = Program(f"RX({trivial_pi}) 0") | ||
| exp = str(prog[0].params[0]) | ||
| assert _eval_as_np_pi(trivial_pi) == _eval_as_np_pi(exp) |
Hmmm semaphore tests passed, so maybe not! |
appleby
approved these changes
Dec 24, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1132. Fixes #1109.
The only remaining excluded
flake8rules are:In addition, adds
flake8-bugbearwhich contains some additional rules (the developers of Black use it, and it's otherwise widely used).Finally, consolidates the style-related
Makefiletargets / CI jobs under a single naming convention:check-all,check-format,check-style, andcheck-types.Checklist
including author and PR number (@username, gh-xxx).