Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Python-based simulation tools to a subdirectory #1143

Merged
merged 9 commits into from
Dec 31, 2019
Merged

Move Python-based simulation tools to a subdirectory #1143

merged 9 commits into from
Dec 31, 2019

Conversation

karalekas
Copy link
Contributor

@karalekas karalekas commented Dec 30, 2019 •
edited
Loading

Description

Fixes #1030. Also adds type hints for the entire module.

Checklist

  • The above description motivates these changes.
  • All new and existing tests pass locally and on Semaphore.
  • Parameters have type hints with PEP 484 syntax.
  • The changelog is updated,
    including author and PR number (@username, gh-xxx).

@karalekas karalekas added devops 🚀 An issue related to CI/CD. quality 🎨 Improve code quality. labels Dec 30, 2019
@karalekas karalekas added this to the v2.16 milestone Dec 30, 2019
@karalekas karalekas requested a review from a team as a code owner December 30, 2019 23:22
appleby
appleby approved these changes Dec 31, 2019
View reviewed changes
pyquil/simulation/__init__.py
@@ -0,0 +1,11 @@
from pyquil.simulation._numpy import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing copyright copypasta

@karalekas karalekas merged commit fc776a1 into master Dec 31, 2019
@karalekas karalekas deleted the simulation-module branch December 31, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby approved these changes

Assignees
No one assigned
Labels
devops 🚀 An issue related to CI/CD. quality 🎨 Improve code quality.
Projects
None yet
Milestone
v2.16
Development

Successfully merging this pull request may close these issues.

Move Python-based simulation tools to a subdirectory
2 participants
@karalekas @appleby