Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dataclasses instead of namedtuples in device module #1149

Merged
merged 5 commits into from
Jan 2, 2020
Merged

Use dataclasses instead of namedtuples in device module #1149

merged 5 commits into from
Jan 2, 2020

Conversation

karalekas
Copy link
Contributor

Description

Fixes #980

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • All code follows Black style and obeys flake8 conventions.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@karalekas karalekas added the refactor 🔨 Rework existing functionality. label Jan 2, 2020
@karalekas karalekas added this to the v2.16 milestone Jan 2, 2020
@karalekas karalekas requested a review from a team January 2, 2020 19:58
@karalekas karalekas requested a review from a team as a code owner January 2, 2020 19:58
appleby
appleby approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pyquil/device/_isa.py Outdated Show resolved Hide resolved
@karalekas karalekas merged commit bc6c046 into master Jan 2, 2020
@ameyer-rigetti ameyer-rigetti deleted the device-dataclasses branch July 12, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby approved these changes

@stylewarning stylewarning stylewarning approved these changes

@notmgsk notmgsk notmgsk approved these changes

Assignees
No one assigned
Labels
refactor 🔨 Rework existing functionality.
Projects
None yet
Milestone
v2.16
Development

Successfully merging this pull request may close these issues.

Change the namedtuples in device.py to dataclasses
4 participants
@karalekas @appleby @stylewarning @notmgsk