Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TomographyExperiment to Experiment #1158

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Rename TomographyExperiment to Experiment #1158

merged 5 commits into from
Jan 9, 2020

Conversation

karalekas
Copy link
Contributor

@karalekas karalekas commented Jan 8, 2020

Description

I prefer the shorter name, and these hybrid/tomography-like experiments are the focus of our quantum cloud platform.

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@karalekas karalekas added the quality 🎨 Improve code quality. label Jan 8, 2020
@karalekas karalekas added this to the v2.16 milestone Jan 8, 2020
@karalekas karalekas requested a review from a team as a code owner January 8, 2020 23:38
Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TomographyExperiment is more descriptive (and easier to grep for), but also it's nice that the pyquil.experiment module exports a thing called Experiment and the symmetry with ExperimentSetting is nice.

pyquil/simulation/tests/test_reference_density.py Outdated Show resolved Hide resolved
pyquil/tests/test_operator_estimation.py Outdated Show resolved Hide resolved
karalekas and others added 3 commits January 9, 2020 08:43
Co-Authored-By: appleby <mappleby@rigetti.com>
Co-Authored-By: appleby <mappleby@rigetti.com>
@karalekas karalekas merged commit 236e85c into master Jan 9, 2020
@karalekas karalekas deleted the experiment branch January 9, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality 🎨 Improve code quality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants