Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand upon the acknowledgements file #1165

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Expand upon the acknowledgements file #1165

merged 2 commits into from
Jan 25, 2020

Conversation

karalekas
Copy link
Contributor

@karalekas karalekas commented Jan 24, 2020 •
edited
Loading

Description

Fixes #1015

Checklist

  • The above description motivates these changes.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@karalekas karalekas added the documentation 📝 An issue for improving docs. label Jan 24, 2020
@karalekas karalekas added this to the v2.17 milestone Jan 24, 2020
@karalekas karalekas requested a review from a team as a code owner January 24, 2020 23:52
@notmgsk
Copy link
Contributor

notmgsk commented Jan 25, 2020 •
edited
Loading

One day @appleby and I will be acknowledged.

@appleby
Copy link
Contributor

appleby commented Jan 25, 2020

u got to earn it. put in the hard years.

@karalekas karalekas merged commit 70f74f8 into master Jan 25, 2020
@karalekas karalekas deleted the update-ack branch January 25, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby approved these changes

@notmgsk notmgsk notmgsk approved these changes

Assignees
No one assigned
Labels
documentation 📝 An issue for improving docs.
Projects
None yet
Milestone
v2.17
Development

Successfully merging this pull request may close these issues.

Update the acknowledgements file
3 participants
@karalekas @notmgsk @appleby