Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compiler connection check timeout user-configurable #1246

Merged
merged 7 commits into from
Sep 5, 2020

Conversation

kalzoo
Copy link
Contributor

@kalzoo kalzoo commented Sep 4, 2020

Description

Closes #1245

  • Clearer error messaging when the QPUCompiler or QVMCompiler times out in network calls
  • No hard-coded timeout values of 1 second in connection to quilc
  • No hard-coded timeout value of 1 second in connection to the translation service (within HTTPCompilerClient)

One downside to these changes is that a user may not have quilc running correctly, and now must wait for the default value of 10 seconds for the error message explaining that the service is not reachable. Given that this is either/or, it seems clearly better to apply the same user-configurable timeout everywhere (as in this PR) than to hard-code it to 1 second (as on master). This way, users can still work with a quilc running under high CPU load.

Checklist

  • The above description motivates these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@kalzoo kalzoo requested a review from a team as a code owner September 4, 2020 05:28
@kalzoo kalzoo changed the title 1245 connection check timeout Make compiler connection check timeout user-configurable Sep 4, 2020
@notmgsk notmgsk merged commit f96932c into master Sep 5, 2020
@ameyer-rigetti ameyer-rigetti deleted the 1245-connection-check-timeout branch July 12, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler connection check timeouts are hard-coded
2 participants