Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed #1256

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Add py.typed #1256

merged 2 commits into from
Oct 14, 2020

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Oct 13, 2020

Description

By including a py.typed in the top-level of the package, any packages that depend on pyquil can validate their types against it with mypy.

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

By including a py.typed in the top-level of the package, any packages
that depend on pyquil can validate their types against it with
mypy.
@notmgsk notmgsk requested a review from a team as a code owner October 13, 2020 13:05
@notmgsk
Copy link
Contributor Author

notmgsk commented Oct 14, 2020

@kalzoo @erichulburd pingu

@notmgsk notmgsk merged commit a882a76 into master Oct 14, 2020
@notmgsk notmgsk mentioned this pull request Oct 15, 2020
@ameyer-rigetti ameyer-rigetti deleted the add-py-typed branch July 12, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant