-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundational support for implementing Program with qcs-sdk-python #1518
Merged
MarquessV
merged 29 commits into
v4-feature-program-implemented-via-qcs-sdk-rust
from
1484-program-api-through-qcs-sdk-rust
Mar 7, 2023
Merged
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0614884
tear out members, start replacing with rust API (WIP)
MarquessV 9abba20
first pass as integrating with qcs_sdk.quil
MarquessV 636e8a9
fix low hanging fruit, introduce snapshot testing for passing tests,
MarquessV 73557e8
update poetry.lock
MarquessV bb6e673
more test annotations, fixes, snapshots
MarquessV 684fcdd
deprecation warnings and cleanup
MarquessV d49521a
Gate tests and snapshots, pre-replacement with quil-rs
MarquessV f7f2a41
add test for FORKED gate
MarquessV f3041ac
back Gate with RSGate
MarquessV 2e7aedf
fix deprecated notice
MarquessV 5d382e7
test improvements
MarquessV 3b44448
more cleanup
MarquessV 7739442
various cleanups
MarquessV a6e6a82
add more snaps
MarquessV ca5b0ac
clean up program per feedback
MarquessV 10f2a1f
feat!: The `calibrations` method on `Program` now only returns `DefCa…
MarquessV e8a0042
update instruction handling logic
MarquessV 8d31abc
deprecate valid protoquil/quilt methods
MarquessV cf97df0
add compatibility layer by overriding quil_rs.Gate superclass methods
MarquessV 1c54abc
remove gate __init__ method
MarquessV 6e53133
remove old comments
MarquessV 0056b2a
revert defcal changes
MarquessV 5f6e8e5
safer type checking on conversion methods
MarquessV 8b11da8
simplify ParameterDesignator Type
MarquessV c1eaab4
forbidden metaclass shenanigans
MarquessV 4097264
Update pyquil/quil.py
MarquessV c293105
use deprecated decorator
MarquessV e7106d3
update qcs-sdk-python dependency spec
MarquessV b093b14
merge feature branch
MarquessV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syrupy
is a snapshot testing plugin for pytest. I've leveraged this in two ways so far:To help get an accurate "before and after
quil-rs
" forGate
. Seetest_quilbase.py
Any other test that was passing and making assertions against a string chock full of escape sequences and white space was replaced with a snapshot test. Planning to do this for most tests, once they pass.