Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realistic noise simulation #1576

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Realistic noise simulation #1576

wants to merge 21 commits into from

Conversation

shrapp
Copy link

@shrapp shrapp commented May 18, 2023

Description

A new realistic noise simulation of Rigetti’s QPU implemented in addition to former features in noise.py

Checklist

  • [v] The PR targets the master branch
  • [v] The above description motivates these changes.
  • [v] The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • [v] Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@shrapp shrapp requested a review from a team as a code owner May 18, 2023 22:06
@shrapp
Copy link
Author

shrapp commented May 18, 2023

@MarquessV

@MarquessV
Copy link
Contributor

Awesome! I've given this a partial review and left some comments, will do another pass later in the week.

pyquil/noise.py Outdated Show resolved Hide resolved
pyquil/noise.py Outdated Show resolved Hide resolved
pyquil/noise.py Outdated Show resolved Hide resolved
pyquil/noise.py Outdated Show resolved Hide resolved
pyquil/noise.py Outdated Show resolved Hide resolved
pyquil/noise.py Outdated Show resolved Hide resolved
shrapp and others added 4 commits June 9, 2023 13:11
Co-authored-by: Marquess Valdez <marquessavaldez@gmail.com>
Co-authored-by: Marquess Valdez <marquessavaldez@gmail.com>
@shrapp
Copy link
Author

shrapp commented Aug 29, 2023

Hi @MarquessV, sorry for the delay. I have just fixed all of your comments and I hope it is ready for push. Thanks!

@shrapp shrapp requested a review from MarquessV September 3, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants