Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compatibility layer will prefer to return DelayFrames, then DelayQubits, then Delay. #1731

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

mac01021
Copy link
Contributor

@mac01021 mac01021 commented Feb 2, 2024

Description

Insert your PR description here. Thanks for contributing to pyQuil! 🙂

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@mac01021 mac01021 requested a review from a team as a code owner February 2, 2024 23:01
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being proactive about this! I have a few follow-up questions.

pyquil/quilbase.py Show resolved Hide resolved
pyquil/quilbase.py Show resolved Hide resolved
test/unit/test_program.py Show resolved Hide resolved
test/unit/test_program.py Outdated Show resolved Hide resolved
test/unit/test_program.py Show resolved Hide resolved
test/unit/test_program.py Show resolved Hide resolved
@MarquessV MarquessV changed the title Tweak conversion logic for Delay instructions fix: Compatibility layer will prefer to return DelayFrames, then DelayQubits, then Delay. Feb 5, 2024
@MarquessV MarquessV merged commit 813a067 into rigetti:master Feb 5, 2024
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants