Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump qcs-sdk-python version to pull DEFCIRCUIT serialization fix #1735

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: bump qcs-sdk-python version to pull DEFCIRCUIT serialization fix #1735

merged 1 commit into from
Feb 7, 2024

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Feb 6, 2024 •
edited
Loading

Description

To pull in a fix to DEFCIRCUIT serialization

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@notmgsk
fix: bump qcs-sdk-python version
da26d25 
To pull in a fix to DEFCIRCUIT serialization
@notmgsk notmgsk marked this pull request as ready for review February 6, 2024 21:33
@notmgsk notmgsk requested a review from a team as a code owner February 6, 2024 21:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7163 6291 88% 87% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: da26d25 by action🐍

MarquessV
MarquessV approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we update the commit message to include that it fixes a DEFCIRCUIT serialization issue.

@notmgsk notmgsk changed the title fix: bump qcs-sdk-python version fix: bump qcs-sdk-python version to pull DEFCIRCUIT serialization fix Feb 7, 2024
@notmgsk notmgsk merged commit 3a50e99 into master Feb 7, 2024
22 checks passed
@notmgsk notmgsk deleted the bump-qcs-sdk branch February 7, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarquessV MarquessV MarquessV approved these changes

@jselig-rigetti jselig-rigetti Awaiting requested review from jselig-rigetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notmgsk @MarquessV