Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove unused rewrite arithmetic logic, deprecate recalculation_table #1787

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

MarquessV
Copy link
Contributor

Description

Closes #1786

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.

Copy link

github-actions bot commented Jul 1, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7216 6330 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_abstract_compiler.py 92% 🟢
pyquil/api/_compiler.py 61% 🟢
pyquil/api/_qpu.py 65% 🟢
TOTAL 72% 🟢

updated for commit: 82c70ba by action🐍

Copy link

github-actions bot commented Jul 2, 2024

🐰Bencher

ReportTue, July 2, 2024 at 22:02:36 UTC
Projectpyquil
Branch1786-remove-rewrite-arithmetic
Testbedci-runner-linux
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
test/benchmarks/test_program.py::test_copy_everything_except_instructions✅ (view plot)10,219,576,522.80 (+0.83%)10,322,504,986.29 (99.00%)
test/benchmarks/test_program.py::test_instructions✅ (view plot)3,949,730,179.60 (-0.56%)4,081,677,608.12 (96.77%)
test/benchmarks/test_program.py::test_iteration✅ (view plot)3,991,505,513.00 (-0.24%)4,157,341,626.24 (96.01%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

reason="The recalculation_table field is no longer used. It will be removed in future versions.",
)
def recalculation_table(self) -> list[str]:
return self._recalculation_table
Copy link
Contributor Author

@MarquessV MarquessV Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated the recalculation_table field to avoid a breaking change.

@MarquessV MarquessV marked this pull request as ready for review July 2, 2024 15:00
@MarquessV MarquessV requested a review from a team as a code owner July 2, 2024 15:00
@MarquessV MarquessV changed the title chore: Remove rewrite_arithmetic and special handling for translation backend V1 feat: Remove unused rewrite arithmetic logic, deprecate recalculation_table Jul 2, 2024
Co-authored-by: Kalan <22137047+kalzoo@users.noreply.github.com>
@MarquessV MarquessV merged commit f516aae into master Jul 2, 2024
24 checks passed
@MarquessV MarquessV deleted the 1786-remove-rewrite-arithmetic branch July 2, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rewrite_arithmetic and related artifacts
2 participants