Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow client to be passed in to get qulit calibrations #1792

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

math411
Copy link
Contributor

@math411 math411 commented Jul 22, 2024

Description

In the case, of a user making calls from the SDK, there will be a missing client for accessing calibration data. The gRPC requests will fail.

Looking at usage of the qcs-sdk without the client passed in: https://github.com/search?q=repo%3Arigetti%2Fpyquil%20qcs_sdk&type=code

Adding in the client that is passed in to the object (or None as this is optional).

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@math411 math411 requested a review from a team as a code owner July 22, 2024 07:19
pyquil/api/_compiler.py Outdated Show resolved Hide resolved
math411 and others added 2 commits July 25, 2024 12:53
@math411 math411 requested a review from MarquessV July 25, 2024 20:07
@math411
Copy link
Contributor Author

math411 commented Jul 25, 2024

I did a pass over files with qcs_sdk. They all seem to have the client passed in but it is possible I have missed some other spot that makes use and misses the client.

pyquil/api/_compiler.py Outdated Show resolved Hide resolved
@math411
Copy link
Contributor Author

math411 commented Jul 25, 2024

Seems that of the workflows are stuck - I may need some help getting these rolling again @MarquessV.

@MarquessV MarquessV merged commit 98b6d02 into rigetti:master Jul 25, 2024
22 checks passed
@MarquessV
Copy link
Contributor

@math411 merged! Thanks for contributing to pyQuil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants