fix: The DefMeasureCalibration instructions property returns pyQuil AbstractInstrctions instead of quil Instructions
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tcion`s instead of `quil` `Instruction`s
|
| Report | Tue, August 13, 2024 at 16:44:35 UTC |
| Project | pyquil |
| Branch | 1798-instructions-property-fix |
| Testbed | ci-runner-linux |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| test/benchmarks/test_program.py::test_copy_everything_except_instructions | ✅ (view plot) | 10,332,968,519.40 (+0.74%) | 10,493,400,802.08 (98.47%) |
| test/benchmarks/test_program.py::test_instructions | ✅ (view plot) | 3,915,241,084.40 (-0.41%) | 4,059,922,179.44 (96.44%) |
| test/benchmarks/test_program.py::test_iteration | ✅ (view plot) | 3,880,498,774.80 (-1.19%) | 4,048,949,509.63 (95.84%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
7 tasks
|
Merging w/ the implicit approval from #1801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1798
pyQuil v3 defined the
instrsproperty onDefMeasureCalibrationas the only way to get the calibrations contained instructions. Thequilcounterpart uses aninstructionsproperty for this purpose. In pyQuil v4, we inherit fromquilbase types, but forDefMeasureCalibration, never overrode theinstructionsproperty, meaning that wheninstructionswas accessed onDefMeasureCalibration,quilclasses were returned. This fix overrides the inherited instruction property and uses the compatibility layer to return pyQuil compatible instructions.Checklist
masterbranch