Add optional memory_map parameter to QuantumComputer.run #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcapelluto
approved these changes
Nov 5, 2018
lcapelluto
reviewed
Nov 5, 2018
ecpeterson
approved these changes
Nov 5, 2018
This PR will only be included in pyquil 2.1 (estimated release date ~Nov30) whereas all of the docs fixes will be released as 2.0.1 shortly; so can you keep them separate for now? |
mpharrigan
reviewed
Nov 5, 2018
pyquil/api/_quantum_computer.py
Outdated
| if memory_map: | ||
| for region_name, values_list in memory_map.items(): | ||
| for offset, value in enumerate(values_list): | ||
| # TODO (karalekas): have write_memory take a list rather than value + offset |
There was a problem hiding this comment.
open an issue and link here?
|
@mpharrigan oh no, the docs are already merged :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #656