add an interleaver option when generating an RB sequence #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
reviewed
Nov 15, 2018
| qubits=qubits, | ||
| gateset=gateset_for_api, | ||
| seed=seed, | ||
| interleaver=interleaver) |
There was a problem hiding this comment.
how does rpcq work? If I upgrade my pyquil but leave interleaver=None, will rpcq accept it or throw an error? if the latter, do we need to bump requirements.txt
There was a problem hiding this comment.
rpcq/messages.py:505: UserWarning: Message RandomizedBenchmarkingRequest ignoring unexpected keyword arguments: interleaver.
It whines, but it doesn't die.
There was a problem hiding this comment.
is that what youre asking @mpharrigan? if you upgrade pyquil but not the reqs?
mpharrigan
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to BenchmarkConnection's RB sequence generator to interleave a fixed Clifford through the sequence.
Depends on rigetti/rpcq#12; do not merge until that is in.