Sundry #674
Merged
Sundry #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
commented
Nov 7, 2018
| @@ -212,7 +212,7 @@ def run_and_measure(self, program: Program, trials: int) -> Dict[int, np.ndarray | |||
| into a 2d numpy array of bitstrings, consider:: | |||
|
|
|||
| bitstrings = qc.run_and_measure(...) | |||
| bitstring_array = np.vstack(bitstrings[q] for q in sorted(qc.qubits())).T | |||
| bitstring_array = np.vstack(bitstrings[q] for q in qc.qubits()).T | |||
There was a problem hiding this comment.
sorted() unnecessary. qc.qubits() guarantees sorting
mpharrigan
commented
Nov 7, 2018
| @@ -351,7 +351,7 @@ def while_do(self, classical_reg, q_program): | |||
| label_start = LabelPlaceholder("START") | |||
| label_end = LabelPlaceholder("END") | |||
| self.inst(JumpTarget(label_start)) | |||
| self.inst(JumpUnless(target=label_end, condition=Addr(classical_reg))) | |||
| self.inst(JumpUnless(target=label_end, condition=classical_reg)) | |||
mpharrigan
commented
Nov 7, 2018
| @@ -632,7 +632,7 @@ def __ne__(self, other): | |||
| return not self.__eq__(other) | |||
|
|
|||
| def __len__(self): | |||
| return len(self._instructions) | |||
| return len(self.instructions) | |||
There was a problem hiding this comment.
include implicit declaration of readout in len()
mpharrigan
commented
Nov 7, 2018
| @@ -304,6 +304,7 @@ class JumpConditional(AbstractInstruction): | |||
| """ | |||
| Abstract representation of an conditional jump instruction. | |||
| """ | |||
| op = NotImplemented | |||
There was a problem hiding this comment.
makes pycharm happy
ecpeterson
approved these changes
Nov 7, 2018
lots! |
lcapelluto
approved these changes
Nov 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see diff