Fix parsing DEFCIRCUIT without qubits #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing a DEFCIRCUIT which has no qubit parameters outputs an
extraneous spacing before the colon:
```
>>> from pyquil.parser import parse
>>> from pyquil._parser.PyQuilListener import run_parser
>>> from pyquil.quilbase import RawInstr
>>> print(run_parser("DEFCIRCUIT TEST:\n MEASURE 0 ro\n"))'
[<RawInstr DEFCIRCUIT TEST :
MEASURE 0 ro[0]>]
```
notmgsk
commented
Nov 13, 2018
| @@ -128,11 +128,12 @@ def exitDefCircuit(self, ctx: QuilParser.DefCircuitContext): | |||
| circuit_name = ctx.name().getText() | |||
| variables = [variable.getText() for variable in ctx.variable()] | |||
| qubitVariables = [qubitVariable.getText() for qubitVariable in ctx.qubitVariable()] | |||
| space = ' ' if qubitVariables else '' | |||
There was a problem hiding this comment.
Not sure if this is the cleanest way to achieve the correct result. The best fix would be to have Circuit in pyquil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing a DEFCIRCUIT which has no qubit parameters outputs an
extraneous spacing before the colon: