Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about QuantumComputer #719

Merged
merged 13 commits into from
Dec 3, 2018

Conversation

lcapelluto
Copy link
Contributor

@lcapelluto lcapelluto commented Nov 29, 2018

Contains clarifying info about QVM, and QPU, as pyQuil objects vs the actual endpoints.
QVM: use from command line, server mode, mention WavefunctionSim
QPU: links to QCS, overview
Quantum Computer: instantiation, run, run_and_measure, making any device topology, simulating qpu w qvm


.. _quantum_computer:

The ``QuantumComputer``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would consider adding a part on getting current QPU performance post-retune in pyQuil (somewhere in here). Might be helpful as users consider what lattice they want to use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I do that as a user? @mpharrigan

Copy link
Contributor

@ryankarle ryankarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see something (at some point) in the get_qc docs showing how to get performance specs (the ones retune posts) in pyQuil. Probably not as important now that we'll be showing that info in the QCS web app, but might still be helpful!

docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@msohaibalam msohaibalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great! A few minor bugs in the code snippets need to be fixed before merging.

docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
docs/source/qvm.rst Outdated Show resolved Hide resolved
lcapelluto and others added 10 commits November 30, 2018 17:07
add missing gate import
typo

Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
amy is awesome

Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
improved wording

Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
Co-Authored-By: lcapelluto <laurencapelluto@gmail.com>
docs/source/qvm.rst Outdated Show resolved Hide resolved
@lcapelluto lcapelluto dismissed msohaibalam’s stale review December 1, 2018 03:16

Sohaib left two comments which I converted to suggestions and committed :)

@lcapelluto lcapelluto merged commit db2b9cc into rigetti:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants