check user lattice name vs compiler lattice name #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PUCompiler in get_qc. check against this name when compiling to binary.
…r warning message
ecpeterson
suggested changes
Jan 23, 2019
pyquil/api/_compiler.py
Outdated
| @@ -160,6 +166,11 @@ def native_quil_to_executable(self, nq_program: Program) -> BinaryExecutableResp | |||
| "Program that hasn't been compiled via `quil_to_native_quil`. This is " | |||
| "ok if you've hand-compiled your program to our native gateset, " | |||
| "but be careful!") | |||
| if self.name is not None: | |||
| targeted_lattice = self.client.call('get_lattice_name') | |||
| if self.client.call('get_lattice_name') != self.name: | |||
There was a problem hiding this comment.
You might also want to guard this against the compiler server returning None. That's not a consideration for external users in their normal mode of operation, but internal users do also use pyQuil against local compiler-server instances. Otherwise (and pending action on the internal PR review), this looks fine to me.
ecpeterson
approved these changes
Jan 23, 2019
mpharrigan
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give QPUCompiler an optional name attribute, use this when building QPUCompiler in get_qc. check against this name when compiling to binary.