Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS and move CODE_OF_CONDUCT to .github #855

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Conversation

karalekas
Copy link
Contributor

No description provided.

@karalekas karalekas added this to the v2.6.0 milestone Mar 20, 2019
@karalekas karalekas requested review from ecpeterson, notmgsk and a team and removed request for ecpeterson and notmgsk March 20, 2019 23:16
Copy link
Contributor

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the utility in having CODE_OF_CONDUCT under .github? Does github care about that file like it does for codeowners?

@karalekas
Copy link
Contributor Author

@notmgsk yes there are a collection of files that GitHub interprets in a special way. These are CONTRIBUTING, CODE_OF_CONDUCT, CODEOWNERS, ISSUE_TEMPLATE, PULL_REQUEST_TEMPLATE, and SUPPORT.

@karalekas
Copy link
Contributor Author

@notmgsk you can either put them in the top-level directory or in .github, and IMO I think it's nice to keep the top level uncluttered when possible

@karalekas karalekas merged commit d1e81a4 into master Mar 21, 2019
@karalekas karalekas deleted the codeowners branch March 21, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants